checking void elements should be case sensitive #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HenrikJoreteg did you already have a bit of time to look at this? |
|
published as |
|
Hey @adrai I made you a contributor on github and gave you publish rights on npm. I think it's safe to say that at this point, you're more invested here than i am. I'm happy to help review code when i can, but I don't want to be a blocker for you. Thanks for your contributions ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in react-i18next: i18next/react-i18next#1304
Seems the
.toLowerCase()change was introduced unintentionally here: ffb47bb#diff-ef2f58723392c7c71346a734e4826c4816aa3e276b95a7d8dc6349939775628cR37 by @kranges