Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stochastic using solver (4 PRs) #14

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Stochastic using solver (4 PRs) #14

merged 3 commits into from
Apr 12, 2024

Conversation

Whebon
Copy link
Contributor

@Whebon Whebon commented Apr 10, 2024

hasdynamicvalue is needed for the rulenode2expr function in HerbGrammar. If an AbstractRuleNode does not have an _eval field set up, then functionality related to this cached/dynamic value should be ignored.

@Whebon Whebon changed the title Stochastic using solver Stochastic using solver (4 PRs) Apr 10, 2024
Copy link
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small changes—otherwise, looks good.

src/rulenode.jl Outdated Show resolved Hide resolved
src/rulenode.jl Show resolved Hide resolved
src/rulenode.jl Outdated Show resolved Hide resolved
Copy link
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ReubenJ ReubenJ merged commit aa83c44 into dev Apr 12, 2024
2 checks passed
@ReubenJ ReubenJ deleted the stochastic-using-solver branch April 12, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants