Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Add functionality to read input-output examples for the basic benchmarks #1

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

jaapdejong15
Copy link
Member

@jaapdejong15 jaapdejong15 commented Dec 21, 2022

Closes Herb-AI/Herb.jl#16

Adds functionality for reading input-output examples for the basic benchmarks

src/Data.jl Outdated
"""
A program synthesis problem that is represented in the form of input-output examples.
"""
struct InputOutputProblem <: ProgramSynthesisProblem
Copy link
Member

@sebdumancic sebdumancic Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for data structures that reflect individual examples:

  • We need an abstract type Example
  • Then make struct IOExample of type Example. This struct has two fields, in and out, and types can be Any.
  • then struct Problem (or maybe better named Task) can contain a vector of Example instances

this makes for a somewhat cleaner interface and could later on mix different types of examples.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also probably leave out 'ProgramSynthesis' from the names of structs. The fact that they are in a program synthesis library indicates their intended purpose :)

Copy link
Member

@sebdumancic sebdumancic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.
Perhaps the praseline_pixels definition can go to the tests, but it is a small thing. We can change later.

@jaapdejong15 jaapdejong15 merged commit a5275ef into master Jan 11, 2023
@jaapdejong15 jaapdejong15 deleted the data_reading branch March 30, 2023 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a function for reading input-output examples to Data.jl
2 participants