Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed color for better color contrast ratio #40

Closed
wants to merge 1 commit into from

Conversation

SaravgiYash
Copy link

Fixes #39

@mmaismma
Copy link
Member

mmaismma commented Oct 20, 2020

You have got two problems with your PR. Hence we can not accept it, please make another PR with the correct changes.

Problem 1

You have changed --themeColor in the correct file i.e. Source/cubfan135/style.css. But for the "Preview", you changed the color in the wrong file. As our contributing guidelines clearly states

Please commit all the changes in the beta version of the tool only. Beta version of anything is located under Source/ with the same rest of the location.

You had to change the CSS file located under Source/cubfan135/style.css.

Problem 2

Further, you had to make a PR to merge into Hermit-Tools:accessibility-improvements but you made the PR to merge into the master branch.
To make a PR merge into another branch select the branch just after you click on "New Pull Request".
image

Don't hesitate to contact me in case. Please make another PR with the correct changes.

@mmaismma mmaismma closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cub] - Color contrast ratio of some elements fail WCAG AA or AAA requirements
2 participants