Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftUI #623

Closed
lvnkmn opened this issue Oct 22, 2019 · 6 comments
Closed

SwiftUI #623

lvnkmn opened this issue Oct 22, 2019 · 6 comments

Comments

@lvnkmn
Copy link
Contributor

lvnkmn commented Oct 22, 2019 •
edited
Loading

What did you do?

I tried to find out if Hero would work in combination with SwiftUI

What did you expect to happen?

I actually expected it would not work.

What happened instead?

It turned out to work out of the box.

General Information

  • Hero Version: 1.4.0

  • iOS Version(s): 13

  • Swift Version: 5

  • Devices/Simulators: iPhone X

  • Reproducible in Examples? (Yes):

Demo Project

https://github.com/CuratoOpenSource/Hero-SwiftUI-example
@lvnkmn
Copy link
Contributor Author

lvnkmn commented Oct 22, 2019 •
edited
Loading

So yeah, against my expectations Hero turned out to work with SwiftUI, since I did not see this documented here I thought this would be worth mentioning.

The demo project that's linked above should show that Hero can be quite easily be used with the new framework.

Since this is not really an issue anymore I'll close it and leave it be for documentation purposes.

Hope this helped!

@lvnkmn lvnkmn closed this as completed Oct 22, 2019
@iDevid
Copy link
Collaborator

iDevid commented Oct 22, 2019

Thank you for the letting us know! This is very interesting 👍

@kuyazee
Copy link
Member

kuyazee commented Oct 29, 2019

Hey @lvnkmn would be great if you could create a PR to add your example maybe to the examples folder

@lvnkmn
Copy link
Contributor Author

lvnkmn commented Oct 29, 2019

@kuyazee sure, I’ll take some time for this on Friday 👌.

@lvnkmn lvnkmn reopened this Oct 29, 2019
@lvnkmn
Copy link
Contributor Author

lvnkmn commented Nov 3, 2019 •
edited
Loading

Sorry, something came up so I could not do this on Friday.

However I started making an appropriate example this evening and will likely create the PR tomorrow.

lvnkmn pushed a commit to lvnkmn/Hero that referenced this issue Nov 4, 2019
ref HeroTransitions#623 - add SwiftUI example
a64a1bd
@lvnkmn lvnkmn mentioned this issue Nov 4, 2019
Closed
lvnkmn pushed a commit to lvnkmn/Hero that referenced this issue Nov 4, 2019
ref HeroTransitions#623 - revert target settings and make sure Exampl…
ab1a2a6 
…e still works (in simulator)
lvnkmn pushed a commit to lvnkmn/Hero that referenced this issue Nov 18, 2019
ref HeroTransitions#623 - improve gitignore, ignore files under .swif…
2f93111 
…tpm directory
lvnkmn pushed a commit to lvnkmn/Hero that referenced this issue Nov 18, 2019
ref HeroTransitions#623 - wrap all swiftUI code in `#if canImport(Swi…
544a2a7 
…ftUI)` statement
lvnkmn pushed a commit to lvnkmn/Hero that referenced this issue Nov 18, 2019
ref HeroTransitions#623 - improve initializer of SwiftUIMatchExampleV…
84adbd5 
…iewController and readability of tuple
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - add SwiftUI example
44fbb6e
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - revert target settings and make sure Example still works (…
9d24742 
…in simulator)
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - improve gitignore, ignore files under .swiftpm directory
f6895ca
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - wrap all swiftUI code in #if canImport(SwiftUI) statement
23b842c
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - improve initializer of SwiftUIMatchExampleViewController a…
f885b7c 
…nd readability of tuple
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - add SwiftUI example
5f7f428
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - revert target settings and make sure Example still works (…
d869db8 
…in simulator)
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - improve gitignore, ignore files under .swiftpm directory
77cb85a
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - wrap all swiftUI code in #if canImport(SwiftUI) statement
33cc4f9
JoeMatt pushed a commit that referenced this issue Dec 12, 2019
@JoeMatt
ref #623 - improve initializer of SwiftUIMatchExampleViewController a…
5c0ef79 
…nd readability of tuple
nick-potts pushed a commit to nick-potts/Hero that referenced this issue Dec 16, 2019
@nick-potts
ref HeroTransitions#623 - add SwiftUI example
3859059
nick-potts pushed a commit to nick-potts/Hero that referenced this issue Dec 16, 2019
@nick-potts
ref HeroTransitions#623 - revert target settings and make sure Exampl…
5b51fee 
…e still works (in simulator)
nick-potts pushed a commit to nick-potts/Hero that referenced this issue Dec 16, 2019
@nick-potts
ref HeroTransitions#623 - improve gitignore, ignore files under .swif…
f76fdef 
…tpm directory
nick-potts pushed a commit to nick-potts/Hero that referenced this issue Dec 16, 2019
@nick-potts
ref HeroTransitions#623 - wrap all swiftUI code in `#if canImport(Swi…
3d9dbad 
…ftUI)` statement
nick-potts pushed a commit to nick-potts/Hero that referenced this issue Dec 16, 2019
@nick-potts
ref HeroTransitions#623 - improve initializer of SwiftUIMatchExampleV…
f912539 
…iewController and readability of tuple
@lvnkmn
Copy link
Contributor Author

lvnkmn commented Apr 1, 2020

Forgot to close this one.

@lvnkmn lvnkmn closed this as completed Apr 1, 2020
JoeMatt added a commit that referenced this issue Feb 8, 2021
@JoeMatt
ref #623 - add SwiftUI example
492768e
JoeMatt added a commit that referenced this issue Feb 8, 2021
@JoeMatt
ref #623 - revert target settings and make sure Example still works (…
a8174e1 
…in simulator)
JoeMatt added a commit that referenced this issue Feb 8, 2021
@JoeMatt @nick-potts
Swift 5 Migration + SwiftUI (#696)
b1a73c4 
* Run Swift 5 Migration Tool

* Inhibit warnings from CollectionKit as it is out of date

* ref #623 - add SwiftUI example

* ref #623 - revert target settings and make sure Example still works (in simulator)

* bundle install and pod install lockfiles

Co-authored-by: Nick Potts <github@nickpotts.com.au>
@unfurl-links unfurl-links bot mentioned this issue Feb 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iDevid @lvnkmn @kuyazee