Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Some small game page fixes #3270

Merged
merged 3 commits into from
Nov 29, 2023
Merged

[UI] Some small game page fixes #3270

merged 3 commits into from
Nov 29, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Nov 26, 2023

This PR fixes 3 small visual issues in the game page in both designs:

Before: In the old design, the proton db rating had no space
image

After:
image

Before: In the new design, the time played popover was behind the next elements
image

After:
image

Before: In the new design, the How Long To Beat row didn't match the design of the other rows
image

After:
image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 26, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team November 26, 2023 22:53
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flavioislima flavioislima merged commit 362a295 into main Nov 29, 2023
@flavioislima flavioislima deleted the redesign-game-page-fixes branch November 29, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants