Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Broken behavior of webview back arrow #3587

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Feb 21, 2024

After this #3426, the back arrow for the webview was actually broken to process the webview's history.

This PR fixes that by adding the webviewGoBack dependency to useCallback so the function gets updated (honestly I don't see the point of using useCallback here, seems like an over-optimization).

Without this fix, the back arrow always takes you to the last heroic screen instead of navigating back inside the webview


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 21, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team February 21, 2024 14:25
@flavioislima flavioislima merged commit d4d19d1 into main Mar 9, 2024
9 checks passed
@flavioislima flavioislima deleted the fix-arrow-back-webview branch March 9, 2024 20:28
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants