Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Type-check Backend & Frontend events #3649

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

CommandMC
Copy link
Collaborator

This adds typechecking for backendEvents and sendFrontendMessage. I've already caught a few issues with this (see #3648, some smaller issues are also corrected here)
Typechecking is done with the usual pattern of an interface holding all possible events/messages, and their corresponding function definitions (similarly to how IPC works, for example)

This is entirely a dev change, no actual code is altered

Requires #3648


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 24, 2024
@CommandMC CommandMC requested a review from a team March 24, 2024 20:54
@CommandMC CommandMC self-assigned this Mar 24, 2024
@CommandMC CommandMC requested review from arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team March 24, 2024 20:54
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@CommandMC CommandMC force-pushed the ref/events-typecheck branch from 52bc8e6 to 7d4d287 Compare March 26, 2024 22:22
@CommandMC CommandMC merged commit 0cbe1ec into main Mar 26, 2024
9 checks passed
@CommandMC CommandMC deleted the ref/events-typecheck branch March 26, 2024 22:46
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants