Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] CustomCSS field for advance persistent styling #4282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 16, 2025

This PR aims to fix 2 problems:

  • When customizing heroic, themes can change the style of the app but users may want to apply changes that are persisted between different themes (like hiding parts of the app, making different elements bigger, moving things around, etc). Currently, the only option to do that is to edit all themes to include the same style.
  • The second problem to solve is to allow users the flexibility to customize things without the need of a full CSS theme and without the need for a specific configuration

For example, this feature can be used to support this feature request #4242 (which was also requested in Discord) by applying this custom CSS

image

(or display: none to fully remove those icons)

Then, any theme that's selected will still have this custom CSS style applied.

Since this can be dangerous (a user could body { display: none } and break everything), there's a warning with an indication on where to update the config files manually, and that's the reason why I put this in Advanced, it's not meant for inexperienced users.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 16, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team January 16, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant