[FIX] Delete GOG manifest if present before install #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
Etaash-mathamsetty,
a team,
flavioislima,
CommandMC,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Jan 31, 2025
| import path from 'path' | ||
| import { existsSync, mkdirSync } from 'graceful-fs' | ||
| import { fixesPath, gogdlConfigPath, isWindows } from 'backend/constants' | ||
| import pathModule from 'path' |
There was a problem hiding this comment.
I had to rename this to pathModule cause path already exists inside the installQueueElement function defined as a variable out of the install params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents an issue that happens when a user tries to install a GOG game but a manifest file already exists in the
manifestsfolder. The installation finishes immediately and there's no clear reason for the user.The solution on discord is always to tell the user to delete this file, we can delete the file automatically before installation just in case.
Use the following Checklist if you have changed something on the Backend or Frontend: