Simplify 'CreateElement', remove potential error in 'AsyncComponent' … #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank Daniel! Indeed! AsyncComponent doesn't accept component as returning value! I will look at failing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a few situations where passing in an array of
numberfor children caused some sub-optimal error messages because TypeScript falls back to the last overload for error reporting. You end up with something like "stringis not assignable toAsyncComponent" which is misleading. So I simplified the overloads in forCreateElement, though this broke a few test cases.It seemed like the root of the break was that type for
AsyncComponentwas slightly inaccurate, which I corrected, but this broke a different test case. I tried it out, and it turns out that test case actually causes Vue to hang, so I've removed it.