Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and cleanup Makefile #185

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Improve and cleanup Makefile #185

merged 1 commit into from
Jun 1, 2023

Conversation

maxlambrecht
Copy link
Contributor

Pull request check list

  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality
N/A

Description of change

  1. Added versions.mk for a cleaner version management.
  2. Reorganized and cleaned up the variable declarations.
  3. Removed unused variables and streamlined the Go installation check.
  4. Added a clean target that removes all build artifacts.
  5. Updated targets for installing toolchains and SQLC.
  6. Removed Docker-related targets as they will be reworked as part of another task to dockerize the Galadriel components.

Which issue this pull requests fixes

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@maxlambrecht
Improve and cleanup Makefile
8698b56 
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
@maxlambrecht maxlambrecht merged commit bb5d985 into HewlettPackard:main Jun 1, 2023
@maxlambrecht maxlambrecht deleted the improve-makefile branch June 1, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victorblsilveira Victorblsilveira Victorblsilveira approved these changes

@mgbcaio mgbcaio mgbcaio approved these changes

@wibarre wibarre Awaiting requested review from wibarre wibarre is a code owner

@mchurichi mchurichi Awaiting requested review from mchurichi mchurichi is a code owner

@jufantozzi jufantozzi Awaiting requested review from jufantozzi jufantozzi is a code owner

Assignees

@maxlambrecht maxlambrecht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxlambrecht @Victorblsilveira @mgbcaio