Add diskutil package for Atomic File Writing Operations
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
maxlambrecht
requested review from
wibarre,
mchurichi,
jufantozzi,
mgbcaio and
Victorblsilveira
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
mgbcaio
approved these changes
Jun 1, 2023
Victorblsilveira
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request check list
Affected functionality
Description of change
This PR introduces the new
diskutilpackage which provides an utility function for performing atomic file write operation using private file mode. This function is essential for ensuring the integrity and consistency of data when writing to disk:AtomicWritePrivateFile(path string, data []byte): This function performs an atomic write operation to a file with private file mode permissions (0600). It handles the process of writing to a temporary file and then renaming it to the intended file path.Changes the "disk" KeyManager to use the
AtomicWritePrivateFilefunction for writing keys to disk.Changes GaladrielClient JWT Token Saving: The function for saving JWT tokens in the GaladrielClient has also been updated to use the
AtomicWritePrivateFilefunction.Which issue this pull requests fixes