Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update, Delete and List operations for Relationships CLI #224

Merged
merged 24 commits into from
Jul 19, 2023

Conversation

mgbcaio
Copy link
Collaborator

@mgbcaio mgbcaio commented Jun 14, 2023

Pull request check list

  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality
Relationship server admin CLI

Description of change
added the ability to perform the update, deletion and listing of relationships.

Which issue this pull requests fixes
GLCP-39474

Copy link
Collaborator

@Victorblsilveira Victorblsilveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mgbcaio thanks for handling that. Just a few comments. Great work.

pkg/server/endpoints/admin.go Show resolved Hide resolved
pkg/server/endpoints/admin.go Show resolved Hide resolved
pkg/server/endpoints/admin.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maxlambrecht maxlambrecht merged commit c31d7a1 into HewlettPackard:main Jul 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants