Improvements and fixes in the X509CA disk #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlambrecht
requested review from
wibarre,
mchurichi,
jufantozzi,
mgbcaio and
Victorblsilveira
as code owners
maxlambrecht
changed the title
pkg/common/x509ca/disk/disk.go
Outdated
Comment on lines
178
to
179
| intermediates := certChain[1:] | ||
| if err := cryptoutil.VerifyCertificateChain([]*x509.Certificate{certChain[0]}, intermediates, bundle, ca.clock.Now()); err != nil { |
There was a problem hiding this comment.
for clarity:
Suggested change
| intermediates := certChain[1:] | |
| if err := cryptoutil.VerifyCertificateChain([]*x509.Certificate{certChain[0]}, intermediates, bundle, ca.clock.Now()); err != nil { | |
| intermediates := certChain[1:] | |
| root := certChain[0] | |
| if err := cryptoutil.VerifyCertificateChain([]*x509.Certificate{root}, intermediates, bundle, ca.clock.Now()); err != nil { |
There was a problem hiding this comment.
That's not correct, certChain[0] is not a root. I defined a variable with the name leafCert instead.
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
…kage Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
maxlambrecht
force-pushed
the
x509ca-disk
branch
from
c1f9a58
to
b6bf611
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Victorblsilveira
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request check list
Affected functionality
Description of change
In this PR, several improvements have been made to the X509CA disk implementation:
Simplify the code and rename the property in the struct from
trustBundletoupstreamChainwhich conveys more clearly that it contains intermediates CAs to chain to an upstream trust bundle.The certificate file can have either a single self-signed (root) certificate or one or more intermediate CAs that chain back to a root CA in the bundle file.
The bundle file should contain one or more trusted root CAs to verify to the certificates in the certificate file.
The certificate chain verification process has been refined to properly utilize both roots and intermediates.
The certificate chain verification process has been refactored into a utility function for re-usability.
Add a logging line when a new X.509 certificate was issued.
Lastly, unit tests have been added for the new utility functions.
Which issue this pull requests fixes