Hypervisor manager #209
Hypervisor manager #209
Conversation
Corrected malformed table
nabhajit-ray
requested review from
AsisBagga,
chebroluharika,
Sowmyahsg,
AnushaY1916,
jyothisgm and
soodpr
Corrected changes placement in the changelog
ov/hypervisor_manager.go
Outdated
| return hypervisorManagers, nil | ||
| } | ||
|
|
||
| func (c *OVClient) AddHypervisorManager(hypM HypervisorManager) error { |
There was a problem hiding this comment.
Instead of AddHypervisorManager keep it as CreateHypervisorManager as this nomenclature is followed in all other resources.
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html | |||
| - Enclosure Group | |||
| - FC Network | |||
| - FCoE Network | |||
| - Hypervisor Managers | |||
There was a problem hiding this comment.
Please keep this resource under an unreleased version. Don't try to update the notes of a released version
There was a problem hiding this comment.
In the PR description, under issues, you have put a link to a PR. Is that PR related to this? Recheck it once.
And under issues, links to issues must be given but not a PR link.
examples/hypervisor_manager.go
Outdated
| ClientOV *ov.OVClient | ||
| hypervisor_manager = "172.18.13.11" | ||
| hypervisor_manager_display_name = "HM2" | ||
| //hypervisor_manager_2 = "eth88" |
There was a problem hiding this comment.
Please remove the commented out code or add a statement on why it is commented
examples/hypervisor_manager.go
Outdated
| ovVer, _ := ovc.GetAPIVersion() | ||
| fmt.Println(ovVer) | ||
| initialScopeUris := &[]utils.Nstring{utils.NewNstring("/rest/scopes/03beb5a0-bf48-4c43-94a5-74b7b5de1255")} | ||
| hypervisorManager := ov.HypervisorManager{DisplayName: "HM1", Name: "172.18.13.11", Username: "dcs", Password: "dcs", Port: 443, InitialScopeUris: *initialScopeUris, Type: "HypervisorManagerV2"} |
There was a problem hiding this comment.
Intend the initialization line by line so it's readable for the customers.
…-golang into HypervisorManager
editied support matrix entry for API 600
…-golang into HypervisorManager
CHANGELOG.md
Outdated
| @@ -13,6 +19,7 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html | |||
| - Enclosure Group | |||
| - FC Network | |||
| - FCoE Network | |||
| - Hypervisor Managers | |||
There was a problem hiding this comment.
Remove the addition here.
| - This release supportsi for API V800,V1000 and V1200 for HypervisorManager resource | ||
|
|
||
| ### Oneview Features supported | ||
| - HypervisorManager | ||
| # [v1.2.0] (2019-12-13) |
There was a problem hiding this comment.
Add space between the version notes
examples/hypervisor_manager.go
Outdated
| InitialScopeUris: *initialScopeUris, | ||
| Type: "HypervisorManagerV2"} | ||
|
|
||
| err := ovc.AddHypervisorManager(hypervisorManager) |
There was a problem hiding this comment.
Rename the function name here as well.
Modified function name as per the resource file
Description
[Added resources file for HypervisorManager supporting API800, API1000, API1200]
Issues Resolved
[]
Check List