Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import nlpsamples files without adding them as attachments #462

Merged
merged 4 commits into from
Dec 25, 2024
Merged

feat: import nlpsamples files without adding them as attachments #462

merged 4 commits into from
Dec 25, 2024

Conversation

yassinedorbozgithub
Copy link
Collaborator

Motivation

The main motivation of this PR is to make the NLP Sample import not saving files as attachments.

Feature demonstration

Supported use cases are :

  • Successful import
    Import.Nlp.samples.webm
  • Duplicated Data
    Import.Nlp.samples.duplicated.data.webm
  • Error
    Import.Nlp.samples.duplicated.data.error.webm

Fixes #461

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub yassinedorbozgithub added the enhancement New feature or request label Dec 17, 2024
@yassinedorbozgithub yassinedorbozgithub self-assigned this Dec 17, 2024
@yassinedorbozgithub yassinedorbozgithub linked an issue Dec 17, 2024 that may be closed by this pull request
🤔 [ISSUE] - saving nlpsample as an attachment #461
Closed
@yassinedorbozgithub yassinedorbozgithub changed the title feat: import nlpsamples files without saving as attachments feat: import nlpsamples files without adding them as attachments Dec 17, 2024
marrouchi
marrouchi requested changes Dec 19, 2024
View reviewed changes
api/src/nlp/controllers/nlp-sample.controller.ts Outdated Show resolved Hide resolved
api/src/nlp/controllers/nlp-sample.controller.ts Outdated Show resolved Hide resolved
frontend/src/components/nlp/components/NlpSample.tsx Outdated Show resolved Hide resolved
@marrouchi marrouchi merged commit bb83cd5 into main Dec 25, 2024
5 checks passed
@yassinedorbozgithub yassinedorbozgithub mentioned this pull request Jan 6, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrouchi marrouchi marrouchi requested changes

Assignees

@yassinedorbozgithub yassinedorbozgithub

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - saving nlpsample as an attachment
2 participants
@yassinedorbozgithub @marrouchi