Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: socketio types #490

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: socketio types #490

merged 1 commit into from
Dec 30, 2024

Conversation

abdou6666
Copy link
Member

@abdou6666 abdou6666 commented Dec 30, 2024 •
edited
Loading

Motivation

This PR fixes issues related to typescrit with socketio & it fixes tests
Fixes # (issue)

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abdou6666 abdou6666 requested a review from marrouchi December 30, 2024 15:51
@abdou6666 abdou6666 self-assigned this Dec 30, 2024
@marrouchi marrouchi merged commit fa8a433 into main Dec 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrouchi marrouchi marrouchi approved these changes

Assignees

@abdou6666 abdou6666

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdou6666 @marrouchi