This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
Run tests on CI #41
Merged
Run tests on CI #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very much just GitHub's suggested node.js workflow file, with the node and action versions changed. I don't know what our minimum requirements are, but their defaults of versions 14.x, 16.x, and 18.x, all failed from missing APIs. As of right now, 20.x and 21.x are both current/active in the release schedule: https://nodejs.org/en/about/previous-releases#release-schedule
|
I expect CI won't run here by default, but you can look at it running on my fork here: https://github.com/AtkinsSJ/phoenix/actions/runs/8139807548?pr=1 |
|
This seems sensible, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much just GitHub's suggested node.js workflow file, with the node and action versions changed. I don't know what our minimum requirements are, but their defaults of versions 14.x, 16.x, and 18.x, all failed from missing APIs. As of right now, 20.x and 21.x are both current/active in the release schedule:
https://nodejs.org/en/about/previous-releases#release-schedule
The build and tests are run whenever a PR is pushed, and whenever commits are pushed to trunk.