Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds German UI translations #88

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Conversation

trueberryless
Copy link
Contributor

add section in translations.ts for German translation

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starlight-blog-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 8:29am

fix apostrophe
@trueberryless
Copy link
Contributor Author

trueberryless commented Oct 16, 2024

Wait, how cool is this automation of the documentation?!?

image

This guy is INSANELY smart again, love it! ❤️
docs/src/components/LanguagesList.astro

Copy link
Contributor

@Ergberg Ergberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trueberryless,

das ist ja toll, danke für die Übersetzung!

even if they are called "prev" and "next", I guess "newer" and "older" better fits the meaning chosen in the other languages.

For "featured", I wondered if "empfohlener Beitrag" would sound more natural, but have no strong opinion (and in deed it is not "recommended").

packages/starlight-blog/translations.ts Outdated Show resolved Hide resolved
Co-authored-by: Ergberg <ergberg@gmx.de>
@trueberryless
Copy link
Contributor Author

For "featured", I wondered if "empfohlener Beitrag" would sound more natural, but have no strong opinion (and in deed it is not "recommended").

Yeah, initially I thought this too, then I changed it because this exact reason, but now that you confirmed that it sounds more natural, I changed it back to "empfohlen"...

Thanks for the tip with prev and next, I confused them with the prev and next buttons on single blog post sites... my bad

* main:
  feat: adds Italian UI translations
Copy link
Owner

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks you both for the translations and the reviews 🌟

@HiDeoo HiDeoo changed the title i18n(de): add German to translations.ts feat: adds German UI translations Oct 22, 2024
@HiDeoo HiDeoo merged commit af0c358 into HiDeoo:main Oct 22, 2024
3 checks passed
@trueberryless trueberryless deleted the patch-2 branch October 22, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants