Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to use NPM for @astropub/md #15

Closed
wants to merge 2 commits into from

Conversation

keturiosakys
Copy link
Contributor

Describe the pull request

Why

When installing the package with Yarn, it fails to resolve gitpkg link in the @astropub/md dependency. Apparently that's due to Yarn likely not being able to resolve query params.

How

Looks like the necessary changes are already published in the NPM version of the package, so this small update replaces the gitpkg link with an NPM link.

Screenshots

Not applicable

Yarn fails to resolve gitpkg links with query params. Looks like the necessary changes are already published in the NPM, so this small update replaces the source link with NPM link
Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starlight-openapi ❌ Failed (Inspect) Dec 11, 2023 2:58pm

@HiDeoo
Copy link
Owner

HiDeoo commented Jan 16, 2024

My apologies, this PR totally slipped through my notifications and I randomly saw it today while fixing unrelated issues in another branch.

As I was in the process of fixing other issues preventing to build this PR and in order to get this out quickly, I've used your fix in my branch and co-authored it with you.

This should be now fixed in v0.4.0 that I've just released.

@HiDeoo HiDeoo closed this Jan 16, 2024
@keturiosakys
Copy link
Contributor Author

No worries, at all and thanks for all your work on this! Just FYI, I've merged a new update to the @astropub/md that's in v0.4.0 dependency that will make it work with Astro 4: astro-community/md#11

@HiDeoo
Copy link
Owner

HiDeoo commented Jan 16, 2024

Just FYI, I've merged a new update to the @astropub/md that's in v0.4.0 dependency that will make it work with Astro 4: astro-community/md#11

Wow, that's an amazing news, thanks a lot. This means that when the upstream Starlight issue preventing the update is fixed, we won't hit again this Yarn issue by just using v0.4.0 🎉

Note: it looks like something is wrong with the https://github.com/astro-community/md repo as it now contains the content of the https://github.com/astro-community/context repo. I'll open an issue.

@keturiosakys keturiosakys deleted the use-npm-version branch January 17, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot add dependency as tar.gz from URL.
2 participants