Introduce new Bambora::Credentials class
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrylewis
force-pushed
the
support-merchant-credential-sets
branch
from
67903c3 to
d71ac84
Compare
harrylewis
force-pushed
the
support-merchant-credential-sets
branch
from
baf0975 to
5a749af
Compare
harrylewis
force-pushed
the
support-merchant-credential-sets
branch
from
5a749af to
441e262
Compare
harrylewis
commented
Feb 1, 2024
Comment on lines
-21
to
+22
| - run: | | ||
| gem install bundler | ||
| bundle config path vendor/bundle | ||
| bundle install --jobs 4 --retry 3 | ||
| - name: Install dependencies | ||
| run: bundle install |
There was a problem hiding this comment.
This step was failing as you can see here. It was failing to install the correct version of bundler for the given Ruby version.
The https://github.com/ruby/setup-ruby GitHub Action comes with Bundler installed by default, so we don't really need to re-install bundler. This ensures a correct version of bundler is installed, and now the tests and linting pass.
jazziining
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code change introduces a new class,
Bambora::Credentials.The intention of this class is to act as a consolidated store of a merchant's API credentials that can be easily referenced and passed around. This can hold a set of sub-merchant credentials or partner merchant credentials.
For now, this class only supports the following credential items.