-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/rdmp 168 aws integration #1924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk/RDMP-168-aws-integration
…sk/RDMP-168-aws-integration
[SetUp] | ||
public void Setup() | ||
{ | ||
_minioClient = new MinioClient() |
Check notice
Code scanning / CodeQL
Static field written by instance method Note test
Write to static field from instance method, property, or constructor.
Rdmp.Core.Tests/DataExport/DataRelease/AWSS3BucketReleaseDestinationTests.cs
Dismissed
Show dismissed
Hide dismissed
Rdmp.Core.Tests/DataExport/DataRelease/AWSS3BucketReleaseDestinationTests.cs
Fixed
Show fixed
Hide fixed
Rdmp.Core.Tests/DataExport/DataRelease/AWSS3BucketReleaseDestinationTests.cs
Fixed
Show fixed
Hide fixed
…cServices/RDMP into task/RDMP-168-aws-integration
JFriel
commented
Aug 16, 2024
JFriel
commented
Aug 16, 2024
Rdmp.Core/DataExport/DataRelease/AWSS3BucketReleaseDestination.cs
Outdated
Show resolved
Hide resolved
JFriel
commented
Aug 16, 2024
JFriel
commented
Aug 16, 2024
…sk/RDMP-168-aws-integration
rdteviotdale
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Release engine block that writes releases to an S3 bucket
Type of change
What types of changes does your code introduce? Tick all that apply.
Checklist
By opening this PR, I confirm that I have: