Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/rdmp 168 aws integration #1924

Merged
merged 41 commits into from
Aug 19, 2024
Merged

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Aug 15, 2024

Proposed Change

Release engine block that writes releases to an S3 bucket

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

@JFriel JFriel requested a review from a team August 15, 2024 15:12
[SetUp]
public void Setup()
{
_minioClient = new MinioClient()

Check notice

Code scanning / CodeQL

Static field written by instance method Note test

Write to static field from instance method, property, or constructor.
Rdmp.Core/ReusableLibraryCode/AWS/AWSS3.cs Fixed Show fixed Hide fixed
@JFriel JFriel removed the request for review from a team August 16, 2024 07:45
@rdteviotdale rdteviotdale merged commit f6d55a3 into develop Aug 19, 2024
7 checks passed
@rdteviotdale rdteviotdale deleted the task/RDMP-168-aws-integration branch August 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants