Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc 492] Re-add repeated bind in match-arm/rule patterns warning #223

Merged

Conversation

LunaAmora
Copy link
Collaborator

This depends on #221, leaving as a draft until that is merged

@LunaAmora LunaAmora self-assigned this Mar 6, 2024
Copy link

This pull request has been linked to Shortcut Story #492: Re-add repeated bind in match warning.

@LunaAmora LunaAmora changed the title [sc 492] Re-add repeated bind in match warning [sc 492] Re-add repeated bind in match-arm/rule patterns warning Mar 6, 2024
src/diagnostics.rs Outdated Show resolved Hide resolved
Copy link
Member

@developedby developedby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

src/term/check/repeated_bind.rs Show resolved Hide resolved
@LunaAmora LunaAmora force-pushed the feature/sc-492/re-add-repeated-bind-in-match-warning branch from 894189b to d522994 Compare March 7, 2024 17:25
@LunaAmora LunaAmora marked this pull request as ready for review March 7, 2024 17:31
@LunaAmora LunaAmora merged commit 90c81f0 into main Mar 7, 2024
5 checks passed
@LunaAmora LunaAmora deleted the feature/sc-492/re-add-repeated-bind-in-match-warning branch March 7, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants