Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint alerts corrections as part of intervention experiment #667

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

evidencebp
Copy link
Contributor

The PR takes care of intervention for this issue as part of an experiment.
The experiment is detailed here

Code uses the pattern
if test:
return True
else:
return False

Pylint alerts on that and suggest a simplification: The if statement can be replaced with 'return bool(test)' (simplifiable-if-statement)

Hence I removed the if and instead returned the test directly.

That simplifies the code and makes it easier to understand.

Code uses the pattern
if test:
    return True
else:
   return False

Pylint alerts on that and suggest a simplification:
The if statement can be replaced with 'return bool(test)' (simplifiable-if-statement)

Hence I removed the if and instead returned the test directly.

That simplifies the code and makes it easier to understand.
@evidencebp
Copy link
Contributor Author

Thanks, @alanhamlett !
Can you also merge it?
This way the projcect will benefit and the experimnet will be able to investigate the change implications.

@alanhamlett
Copy link
Contributor

Thanks, @alanhamlett ! Can you also merge it? This way the projcect will benefit and the experimnet will be able to investigate the change implications.

I have no idea what that sentence means... Either way I don't have merge permission on this repo.

@evidencebp
Copy link
Contributor Author

@alanhamlett ,part of the experiment design is the see if tendency to bugs, time to modify the code, etc. improve due to the change.

@yigitguler, I see that you did the recent merges in this repository.
Can you merge the PR?

@alanhamlett
Copy link
Contributor

@alanhamlett ,part of the experiment design is the see if tendency to bugs, time to modify the code, etc. improve due to the change.

@yigitguler, I see that you did the recent merges in this repository. Can you merge the PR?

Waste of time

@evidencebp
Copy link
Contributor Author

It is a minor change.
I don't expect it to have a huge influence on the file.
However, quantifying the mederate (or even lack of) benefit of alerts is an importnat contribution for SE research.

And since the PR is already written and approved, just merging it require almost no time.
This way the time that we already invested won't be wasted ;-)

@yigitguler yigitguler merged commit 5e6782c into Hipo:master Oct 15, 2024
1 check passed
@yigitguler
Copy link
Member

Lets see what happens.

@yigitguler
Copy link
Member

To me, the difference should be negligible.

@alanhamlett
Copy link
Contributor

Thanks @evidencebp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants