-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pylint alerts corrections as part of intervention experiment #667
Conversation
Code uses the pattern if test: return True else: return False Pylint alerts on that and suggest a simplification: The if statement can be replaced with 'return bool(test)' (simplifiable-if-statement) Hence I removed the if and instead returned the test directly. That simplifies the code and makes it easier to understand.
Thanks, @alanhamlett ! |
I have no idea what that sentence means... Either way I don't have merge permission on this repo. |
@alanhamlett ,part of the experiment design is the see if tendency to bugs, time to modify the code, etc. improve due to the change. @yigitguler, I see that you did the recent merges in this repository. |
Waste of time |
It is a minor change. And since the PR is already written and approved, just merging it require almost no time. |
Lets see what happens. |
To me, the difference should be negligible. |
Thanks @evidencebp |
The PR takes care of intervention for this issue as part of an experiment.
The experiment is detailed here
Code uses the pattern
if test:
return True
else:
return False
Pylint alerts on that and suggest a simplification: The if statement can be replaced with 'return bool(test)' (simplifiable-if-statement)
Hence I removed the if and instead returned the test directly.
That simplifies the code and makes it easier to understand.