refactor(dependencies): Move MAUS dependencies to kohlrahbi #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-krechan
changed the title
…rshmallow` (#414) * first steps * add pyproject.toml * update requirements.txt * refactor _check_that_string_is_not_whitespace_or_empty() function * fix validation function * import pydantic * refactor AhbMetaInformation to Pydantic * refactor DataElement * Refactor DataElementFreeText * Refactor class ValuePoolEntry * remove wrong 'always' parameter * refactor DataElementValuePool * Refactor DataElementValuePool * Refactor SegmentLevel * remove attr import * Refactor class Segment(SegmentLevel): * refactor SegmentGroup * Refactor EdifactStackLevel * fix unit test * fix another test * refactor _FreeTextOrValuePool * remove unused import attrs * refactor EdifactStack * fix * remove schema * Remove SegmentGroupSchema * fix test_empty_entered_input_is_not_dumped * 🚧 WIP * WIP * refactor: Remove Class `_FreeTextOrValuePool` (#416) * remove class _FreeTextOrValuePool * remove to upper * remove entered_input validator * remove extra validator for value_type * remove entered_input or replace it with free_text * remove expected_json_dict in test * remove test test_empty_entered_input_is_not_dumped * add value_type even it is default * clean up serialization test * more clean up in serialization_test_helper * remove unused imports * change line ending to LF * remove functions which are releated to entered_input * Add module docstring * use pattern r'^\S+$' to validate non empty or whitespace string * use min_length=1 to check non-empty strings * use list as typehint instead of List * replace validate_ahb_expression with pydantic on board options * remove unused import List * remove AhbLineSchema * replace field validator for ahb_expression * Revert "remove AhbLineSchema" This reverts commit 804c5a4. * fix marshmallow * remove check check_string_is_not_whitespace_or_empty * remove unused import * remove another unused import * remove further unnecessary validators * remove unsued imports * please mypy * use str instead of Any * remove unused import of Any * refactor FlatAnwendungshandbuch * put comments into description * Refactor DeepAhbInputReplacement * ➕ add pylint-pydantic and update requirements * refactor DeepAnwendungshandbuch * remove attrs imports * add return type hint * add test_ahb_from_maus tests and replace the import paths * easy fixes for new maus tests * bring back the method replace_inputs_based_on_discriminator * update serialization roundtrip test * add test for replace_inputs_based_on_discriminator * refactor _replace_inputs_based_on_discriminator * fix mypy issues * use lowercase for type hints * use lowercase typehint for dict and list * Remove marshmallow Schemas * remove unused ignore statement * 🎉 remove attrs and marshmallow * fix typo * remove hopefully last attrs class
8 tasks
8 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first step to get rid of the MAUS dependencies I copied all functions and classes from MAUS into kohlrahbi inclusive tests.
It replaces the attrs classes in kohlrahbi and maus with pydantic classes and removes all marshmallow schemas.