Clouds, Terrain cache and more #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultrazar
commented
Jul 2, 2021
| terrain_job = PGGlobals.queue_terrain_patch(data) | ||
| terrain_job.connect("job_finished", self, "on_patch_finished", [], CONNECT_DEFERRED) | ||
|
|
||
|
|
||
| # Update this node in the quadtree. | ||
| func visit(): | ||
| var viewer_in_range: bool = \ | ||
| _viewer_node.global_transform.origin.distance_to(_center) \ | ||
| _viewer_node.global_transform.origin.distance_to(planet.to_global(_center)) \ |
There was a problem hiding this comment.
There was a bug, don't load correct patches when rotating the planet. Solved with to_global function
|
Cool! I will check this stuff out |
|
Clouds are looking good already! So while checking this out, I spotted a problem with the cloud shader, it warps towards the poles of the planetary sphere, because the vertex distribution is like that on a UV sphere. Also, could you rebase this PR onto the latest commit onto the dev branch, 1ddb9bd? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on an online HTML5 game where you can explore the space.
Here a pull request with the most interesting changes that I made.
That are: