Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cjg/2pkgs #27

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Cjg/2pkgs #27

merged 3 commits into from
Jan 8, 2019

Conversation

Cody-G
Copy link
Contributor

@Cody-G Cody-G commented Jan 8, 2019

This integrates two dependencies of ImagineInterface: ImagineHardware and UnitAliases.

The reason I'm not including ImagineInterface in this PR is that I don't want to lock us into a particular ImagineInterface sha until I see that tests pass for my latest PR. And I can't check whether tests pass without adding these dependencies to the registry. In this case it's no big deal, but this kind of workflow could lead to tedium in the future: I think this means that if we update multiple packages in the dependency tree at the same time then we'll need to make several incremental PRs here in the registry if we want to be sure that CI tests pass before merging changes (and generally we do want that).

@timholy
Copy link
Member

timholy commented Jan 8, 2019

Related: JuliaLang/Pkg.jl#770. Though you've identified a limitation in the proposed solution!

@kdw503
Copy link
Contributor

kdw503 commented Jan 8, 2019

Yes, I also thought that it is so tedious to update version number and sha value every time a package is changed.
So, I thought that why they didn't get those information directly from individual package repositories and registry only have the location of these repositories.
But, it has a benefit that when we add a package all the version conflicts of dependencies can be resolved or detected with this registry information before actual pulling of every dependency.
That means adding package has less errors and is faster. Actually, I often experienced hard time when I add new package in old package system.
Maybe, regular package users will feel better than before once they understand new package ecosystem.

@kdw503 kdw503 merged commit 4e4347a into master Jan 8, 2019
@kdw503
Copy link
Contributor

kdw503 commented Jan 8, 2019

I think you also have privilege to merge. You don't need to wait next time.

@kdw503 kdw503 deleted the cjg/2pkgs branch January 8, 2019 15:20
@Cody-G
Copy link
Contributor Author

Cody-G commented Jan 8, 2019

I think you also have privilege to merge. You don't need to wait next time.

Got it, thanks! Since this was my first time adding to the registry I wanted to make sure you could check my work before merging.

@Cody-G
Copy link
Contributor Author

Cody-G commented Jan 8, 2019

Related: JuliaLang/Pkg.jl#770. Though you've identified a limitation in the proposed solution!

Thanks for pointing that out! I've brought up the point there, we'll see how it fares :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants