Skip to content

Commit

Permalink
Redbox: skip column number if it is 0 in Android.
Browse files Browse the repository at this point in the history
Summary:
As for symbolicated stack trace in the red box in Android, make column number not shown if it's zero.

Format Before:
{F61180667}

Format After:
{F61180666}

Reviewed By: mkonicek

Differential Revision: D3358317

fbshipit-source-id: 87981e678e22ab9f483727002175c8835941ceee
  • Loading branch information
Siqi Liu authored and Morgan Pretty committed Aug 24, 2016
1 parent 77a2b10 commit 996cc53
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ public View getView(int position, View convertView, ViewGroup parent) {
FrameViewHolder holder = (FrameViewHolder) convertView.getTag();
holder.mMethodView.setText(frame.getMethod());
final int column = frame.getColumn();
final String columnString = column < 0 ? "" : ":" + column;
// If the column is 0, don't show it in red box.
final String columnString = column <= 0 ? "" : ":" + column;
holder.mFileView.setText(frame.getFileName() + ":" + frame.getLine() + columnString);
return convertView;
}
Expand Down

0 comments on commit 996cc53

Please sign in to comment.