Merge pull request #2678 from reitermarkus/fix-cli-default-options

Fix cli default options.
Homebrew · May 24, 2017 · a3e30a1 · a3e30a1
2 parents c6c8725 + b91d025
commit a3e30a1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/Library/Homebrew/cask/lib/hbc/cli/options.rb b/Library/Homebrew/cask/lib/hbc/cli/options.rb
@@ -24,10 +24,12 @@ def option(name, method, default_value = nil)
 
           if [true, false].include?(default_value)
             define_method(:"#{method}?") do
+              return default_value unless instance_variable_defined?(:"@#{method}")
               instance_variable_get(:"@#{method}") == true
             end
           else
             define_method(:"#{method}") do
+              return default_value unless instance_variable_defined?(:"@#{method}")
               instance_variable_get(:"@#{method}")
             end
           end

diff --git a/Library/Homebrew/test/cask/cli_spec.rb b/Library/Homebrew/test/cask/cli_spec.rb
@@ -13,6 +13,13 @@
                           ])
   end
 
+  context "when no option is specified" do
+    it "--binaries is true by default" do
+      command = Hbc::CLI::Install.new("some-cask")
+      expect(command.binaries?).to be true
+    end
+  end
+
   context "::run" do
     let(:noop_command) { double("CLI::Noop") }