Skip to content

Commit

Permalink
rubocops/lines: Clean up an old TODO
Browse files Browse the repository at this point in the history
- I considered writing a cop for this, but it's not worth it:
  there are no `[:test, :build]` occurrences in Core and this
  Rust rule only applies in Core formulae.
  • Loading branch information
issyl0 committed Feb 9, 2025
1 parent be00598 commit d9b376a
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions Library/Homebrew/rubocops/lines.rb
Original file line number Diff line number Diff line change
Expand Up @@ -938,9 +938,7 @@ def audit_formula(formula_nodes)
end
end

# TODO: Enforce order of dependency types so we don't need to check for
# depends_on "rustup" => [:test, :build]
[:build, [:build, :test], [:test, :build]].each do |type|
[:build, [:build, :test]].each do |type|

Check warning on line 941 in Library/Homebrew/rubocops/lines.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/rubocops/lines.rb#L941

Added line #L941 was not covered by tests
find_method_with_args(body_node, :depends_on, "rustup" => type) do
problem "Formulae in homebrew/core should use 'depends_on \"rust\" => #{type}' " \
"instead of '#{@offensive_node.source}'." do |corrector|
Expand Down

0 comments on commit d9b376a

Please sign in to comment.