upgrade: tell people that --all is a no-op. #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently this is still run by people so let's tell them to save some typing.
zmwangx
approved these changes
Oct 1, 2016
alyssais
approved these changes
Oct 1, 2016
DomT4
approved these changes
Oct 1, 2016
| @@ -23,6 +23,14 @@ def upgrade | |||
|
|
|||
| Homebrew.perform_preinstall_checks | |||
|
|
|||
| if ARGV.include?("--all") | |||
| opoo <<-EOS.undent | |||
| We decided to not change the behaviour of `brew upgrade` so | |||
There was a problem hiding this comment.
This could probably be compressed into a simple:
opoo "`--all` on `brew upgrade` is no longer necessary."but if you're happy with the longer explanation, 👍.
|
Will keep it verbose for now as people may get confused otherwise and slim down in future. |
alrra
added a commit
to alrra/dotfiles
that referenced
this pull request
Oct 5, 2016
" Warning: We decided to not change the behaviour of `brew upgrade` so `brew upgrade --all` is equivalent to `brew upgrade` without any other arguments (so the `--all` is a no-op and can be removed) " - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref: Homebrew/brew#1202
wingy3181
added a commit
to wingy3181/dotfiles
that referenced
this pull request
Oct 12, 2016
" Warning: We decided to not change the behaviour of `brew upgrade` so `brew upgrade --all` is equivalent to `brew upgrade` without any other arguments (so the `--all` is a no-op and can be removed) " - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref: Homebrew/brew#1202 Cherry-picked from alrra@dc68579
This was referenced Jan 10, 2017
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Apparently this is still run by people so let's tell them to save some typing.
CC @alyssais and @DomT4 who mentioned this.