Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shims/linux: add gnumake and gmake symlinks #15531

Merged
merged 1 commit into from
Jun 6, 2023
Merged

shims/linux: add gnumake and gmake symlinks #15531

merged 1 commit into from
Jun 6, 2023

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jun 6, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The opencv@3 build calls gmake, which ends up evading our compiler
shim and results in a build failure because of a -Werror flag.

Closes Homebrew/homebrew-core#132966.

The `opencv@3` build calls `gmake`, which ends up evading our compiler
shim and results in a build failure because of a `-Werror` flag.

Closes Homebrew/homebrew-core#132966.
@carlocab carlocab added the critical Critical change which should be shipped as soon as possible. label Jun 6, 2023
@carlocab carlocab enabled auto-merge June 6, 2023 15:52
@carlocab carlocab merged commit e37650d into Homebrew:master Jun 6, 2023
@carlocab carlocab deleted the linux-make-shims branch June 6, 2023 16:07
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @carlocab!

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants