Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/linux/ld: harden brewed_ld_so_diagnostics against TypeError #18333

Merged
merged 3 commits into from
Sep 17, 2024

Commits on Sep 16, 2024

  1. os/linux/ld: harden brewed_ld_so_diagnostics against TypeError

    I think this is a bug in Ruby, but I've no idea how to track it down. I
    can reproduce it intermittently in a codespace when `brew install`ing a
    large number of formulae.
    
    To work around this:
    - cache the return value of `brewed_ld_so_diagnostics` so that we can
      limit the number of calls to `IO.popen`
    - retry once when we see a `TypeError`
    
    Closes #17828.
    carlocab committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bb20b3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    70ab493 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. os/linux/ld: drop retry logic

    This is a hack, so let's see if we can get away with skipping it for
    now.
    carlocab committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1656d08 View commit details
    Browse the repository at this point in the history