Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shims/super/cc: remove leftover usage of llvm-g++-4.2 #18460

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 29, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Not sure if there is a situation this needs to be forwarded to another compiler. I think most support forllvm-g* usage was removed in my last PR that dropped the shims

@Bo98
Copy link
Member

Bo98 commented Sep 29, 2024

You'll probably want to remove the remaining *llvm-g* shims too if doing this: https://github.com/Homebrew/brew/tree/master/Library/Homebrew/shims/super. llvm-g++-4.2 in particular still exists.

They are no longer ever used.
@MikeMcQuaid
Copy link
Member

You'll probably want to remove the remaining *llvm-g* shims too if doing this: master/Library/Homebrew/shims/super. llvm-g++-4.2 in particular still exists.

@Bo98 Good shout. Done.

@MikeMcQuaid MikeMcQuaid merged commit 929a1b1 into master Sep 30, 2024
27 checks passed
@MikeMcQuaid MikeMcQuaid deleted the shim-llvm-gcc branch September 30, 2024 07:53
@MikeMcQuaid
Copy link
Member

Thanks @cho-m!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants