Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keg_relocate: fix error when dylib_id doesn't need changing #18638

Merged
merged 1 commit into from
Oct 26, 2024
Merged

keg_relocate: fix error when dylib_id doesn't need changing #18638

merged 1 commit into from
Oct 26, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 26, 2024 

Error: Parameter 'id': Expected type String, got type NilClass
Caller: /opt/homebrew/Library/Homebrew/extend/os/mac/keg_relocate.rb:31
Definition: /opt/homebrew/Library/Homebrew/os/mac/keg.rb:6 (Keg#change_dylib_id)

While we're here, since runtime TypeErrors are usually an indication of insufficient static typing, fix up signatures so that the static typechecker could catch this bug in the future.

@Bo98 Bo98 merged commit b34e6ee into master Oct 26, 2024
27 checks passed
@Bo98 Bo98 deleted the keg_relocate-type-fix branch October 26, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bo98 @carlocab