Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/github: handle over 30 changed files #18933

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 14, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Related to issue seen while working on Homebrew/homebrew-core#198115 and temporary alternative CODEOWNERS in Homebrew/homebrew-core#201069

Before

brew(main):001> GitHub.get_pull_request_changed_files("Homebrew/homebrew-core", 198115).size
=> 30
brew(main):002> GitHub.get_pull_request_changed_files("Homebrew/homebrew-core", 198115).last["filename"]
=> "Formula/l/leela-zero.rb"

After

brew(main):001> GitHub.get_pull_request_changed_files("Homebrew/homebrew-core", 198115).size
=> 77
brew(main):002> GitHub.get_pull_request_changed_files("Homebrew/homebrew-core", 198115).last["filename"]
=> "Formula/z/znc.rb"

@carlocab carlocab added this pull request to the merge queue Dec 14, 2024
Merged via the queue into master with commit ccb463b Dec 14, 2024
28 checks passed
@carlocab carlocab deleted the no-conflicts-paginate branch December 14, 2024 08:43
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlocab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants