Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Sorbet typed: strict RuboCops #19195

Merged
merged 1 commit into from
Feb 10, 2025
Merged

More Sorbet typed: strict RuboCops #19195

merged 1 commit into from
Feb 10, 2025

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 2, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@issyl0 issyl0 force-pushed the sorbet-strict-more-rubocops branch 3 times, most recently from 5345b15 to 9350366 Compare February 8, 2025 15:03
@issyl0
More Sorbet typed: strict RuboCops
0fc1eb5 
- Some of these I bumped to `typed: strict`, some of them I added
  intermediary type signatures to some of the methods to make my life
  easier in the (near, hopefully) future.
- Turns out that RuboCop node matchers that end in `?`
  can return `nil` if they don't match anything, not `false`.
@issyl0 issyl0 force-pushed the sorbet-strict-more-rubocops branch from 9350366 to 0fc1eb5 Compare February 8, 2025 23:38
@issyl0 issyl0 marked this pull request as ready for review February 9, 2025 00:18
p-linnane
p-linnane approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@issyl0 issyl0 added this pull request to the merge queue Feb 10, 2025
Merged via the queue into master with commit 87b61a2 Feb 10, 2025
28 checks passed
@issyl0 issyl0 deleted the sorbet-strict-more-rubocops branch February 10, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issyl0 @p-linnane