Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/lines: Clean up an old TODO #19277

Merged
merged 2 commits into from
Feb 11, 2025
Merged

rubocops/lines: Clean up an old TODO #19277

merged 2 commits into from
Feb 11, 2025

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 9, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • I considered writing a cop for this, but it's not worth it: there are no [:test, :build] occurrences in Core and this Rust rule only applies in Core formulae.

- I considered writing a cop for this, but it's not worth it:
  there are no `[:test, :build]` occurrences in Core and this
  Rust rule only applies in Core formulae.
Co-authored-by: Carlo Cabrera <github@carlo.cab>
@issyl0 issyl0 added this pull request to the merge queue Feb 11, 2025
Merged via the queue into master with commit bb56089 Feb 11, 2025
30 checks passed
@issyl0 issyl0 deleted the rm-old-todo branch February 11, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants