Deprecate --caskroom flag.
#2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorgalvao
reviewed
May 23, 2017
| @@ -255,7 +252,7 @@ Environment variables specific to Homebrew-Cask: | |||
| the command-line. This is particularly useful to make options persistent. | |||
| For example, you might add to your .bash_profile or .zshenv something like: | |||
|
|
|||
| export HOMEBREW_CASK_OPTS='--appdir=/Applications --caskroom=/etc/Caskroom' | |||
| export HOMEBREW_CASK_OPTS='--appdir=/Applications --fontdir=/Library/Fonts' | |||
There was a problem hiding this comment.
Instead of --appdir=/Applications, it should be --appdir=~/Applications, since /Applications is now the default, you wouldn’t set a flag for it.
reitermarkus
force-pushed
the
deprecate-caskroom-flag
branch
from
ecc98bd to
611adfa
Compare
vitorgalvao
approved these changes
May 23, 2017
reitermarkus
force-pushed
the
deprecate-caskroom-flag
branch
from
bc801ae to
c1adbbd
Compare
miccal
approved these changes
May 23, 2017
reitermarkus
force-pushed
the
deprecate-caskroom-flag
branch
6 times, most recently
from
a7c0edb to
4a4820e
Compare
reitermarkus
force-pushed
the
deprecate-caskroom-flag
branch
from
4a4820e to
68a5130
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?cc @adidalal, @claui, @fanquake, @miccal, @victorpopkov
Closes Homebrew/homebrew-cask#21858.