Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_desc_cop: Whitelist "etc." and fix the full stop autocorrect #3411

Merged
merged 2 commits into from
Nov 19, 2017

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Nov 1, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • [] Have you successfully run brew tests with your changes locally?

As per #2795 (comment), here's a PR to whitelist "etc." only in the full stop format_desc_cop, and fix the autocorrect so it works with quotes at the end of the line too. I ran a brew audit --strict and it stopped complaining about formulae with etc. at the end.

@issyl0 issyl0 force-pushed the whitelist_etc_and_fix_autocorrect branch from ddd9f6f to c21a868 Compare November 1, 2017 19:23
Isabell Long added 2 commits November 1, 2017 19:50
@issyl0 issyl0 force-pushed the whitelist_etc_and_fix_autocorrect branch from c21a868 to 5cbb414 Compare November 1, 2017 19:51
@MikeMcQuaid
Copy link
Member

Looks good, thanks @issyl0! Would you mind writing some tests to check these work as expected? Thanks again!

@MikeMcQuaid
Copy link
Member

@issyl0 Any news on that? If you'd rather not: no worries.

@issyl0
Copy link
Member Author

issyl0 commented Nov 10, 2017

Sorry @MikeMcQuaid, this week has been stupidly busy and I'm unlikely to get time to do this soon. Sorry for leaving this hanging too. Also, from what I can see, the existing tests always test that violations are reported, not that they're ignored, if that makes any sense, and negating that for this one case feels odd.

@MikeMcQuaid MikeMcQuaid merged commit c6a5bba into Homebrew:master Nov 19, 2017
@MikeMcQuaid
Copy link
Member

Will merge without tests this time but please write some in future. Thanks @issyl0!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
@issyl0 issyl0 deleted the whitelist_etc_and_fix_autocorrect branch November 4, 2022 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants