diagnostic: check if Xcode needs CLT installed. #3453
Conversation
Library/Homebrew/os/mac.rb
Outdated
| def latest_version? | ||
| version == latest_version | ||
| end | ||
|
|
||
| def prerelease? | ||
| # TODO: bump version when new OS is released |
There was a problem hiding this comment.
probably should relocate the comment
|
If you're using Xcode 10 on 10.13, and if we haven't bumped the i.e. it's OK not to have CLT if your macOS version == macOS 10.13 && your Xcode version < Xcode 10 |
Library/Homebrew/os/mac.rb
Outdated
| @@ -31,9 +31,17 @@ def full_version=(version) | |||
| @version = nil | |||
| end | |||
|
|
|||
| def latest_version | |||
| Version.new "10.13" | |||
There was a problem hiding this comment.
just checking that these versions won't ever have a patch number (10.13.1)?
There was a problem hiding this comment.
this gets compared to version not full_version so it should be ok I think
There was a problem hiding this comment.
yeah, it looks like version just has 10.minor
https://github.com/Homebrew/brew/blob/master/Library/Homebrew/os/mac.rb#L19-L21
thanks!
Require the CLT on all but the latest version of macOS to avoid the continuous workarounds for SDK weirdness.
|
The error message for this patch is terribly confusing and diverts people from the actual problem/solution.
versus:
There needs to be a proper distinction between "Xcode alone" vs "you don't have the latest SDK"... Also, why do I need the latest SDK if I'm building for my current OS revision? Especially considering the SDK version doesn't determine build-ability? 99+% of the ports don't even touch the SDK, do they? |
Original unedited message that I got emailed "The error message for this patch is terrible".
I have no interest in answering your questions if you are going to be rude. |
Require the CLT on all but the latest version of macOS to avoid the continuous workarounds for SDK weirdness.