New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lines_cop: Add condition to prevent false positives #3478

Merged

MikeMcQuaid merged 1 commit into Homebrew:master from GauthamGoli:dir_audit_bug_fix

Nov 24, 2017

Contributor

GauthamGoli commented Nov 24, 2017 •

edited

Loading

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
[] Have you written new tests for your changes? Here's an example.
Have you successfully run brew tests with your changes locally?

Fixes this bug
Homebrew/homebrew-core#18736
Homebrew/homebrew-core#18736 (comment)

This was the original audit rule.

if line =~ /(Dir\[("[^\*{},]+")\])/
      problem "#{Regexp.last_match(1)} is unnecessary; just use #{Regexp.last_match(2)}"
end

Issue: I was just running the check on first argument without checking number of arguments but original rule I think doesn't match multiple arguments


          lines_cop: Add condition to prevent false positives

9be8538

MikeMcQuaid approved these changes

View reviewed changes

MikeMcQuaid merged commit 6c23892 into Homebrew:master

Member

MikeMcQuaid commented Nov 24, 2017

Thanks again @GauthamGoli!

Homebrew locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet