Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lines_cop: Convert ARGV audit to negative look ahead #3518

Merged
merged 1 commit into from
Dec 2, 2017

Conversation

GauthamGoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Homebrew/homebrew-core#18736 (comment)

Original audit rule was a negative look ahead, where as the RuboCop audit was implemented as positive lookahead. This PR Fixes it.

original audit rule:

if line =~ /ARGV\.(?!(debug\?|verbose\?|value[\(\s]))/
   problem "Use build instead of ARGV to check options"
end

cc @ilovezfs

@ilovezfs
Copy link
Contributor

ilovezfs commented Dec 2, 2017

Thanks @GauthamGoli :)

@MikeMcQuaid MikeMcQuaid merged commit 780e869 into Homebrew:master Dec 2, 2017
@MikeMcQuaid
Copy link
Member

Thanks again @GauthamGoli!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants