Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caveats: fix PKG_CONFIG_PATH nudge under env filtering #3552

Merged
merged 1 commit into from
Dec 11, 2017
Merged

caveats: fix PKG_CONFIG_PATH nudge under env filtering #3552

merged 1 commit into from
Dec 11, 2017

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Dec 11, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

Does what it says on the tin.

@MikeMcQuaid MikeMcQuaid merged commit 129ca7e into Homebrew:master Dec 11, 2017
@MikeMcQuaid
Copy link
Member

Thanks again @DomT4!

@DomT4 DomT4 deleted the caveats branch December 11, 2017 09:13
@DomT4
Copy link
Member Author

DomT4 commented Dec 11, 2017

Thanks Mike! Minor follow-up in #3554 for something I didn't spot till just now.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DomT4 @MikeMcQuaid