post_install: use HOMEBREW_PATH. #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this instead of appending the `HOMEBREW_PREFIX` as it's more reliable at finding e.g. keg-only and requirement PATH additions. It's not ideal as it overrides some environment filtering but the only real alternative is recreate the entire build environment by shelling out to `build.rb` in `formula_installer`.
ilovezfs
approved these changes
Dec 15, 2017
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this instead of appending the
HOMEBREW_PREFIXas it's more reliable at finding e.g. keg-only and requirement PATH additions. It's not ideal as it overrides some environment filtering but the only real alternative is recreate the entire build environment by shelling out tobuild.rbinformula_installer.CC @ilovezfs