Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.sh: Use shims/scm/git for HOMEBREW_VERSION #3588

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Dec 21, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Move the use of git to determine HOMEBREW_VERSION below the definition of the function git.

Move the use of git to determine HOMEBREW_VERSION below the
definition of the function git.
@alyssais
Copy link
Contributor

Can you describe what the effects of this change are? I think I could guess but don't want to make a wrong assumption.

@MikeMcQuaid
Copy link
Member

LGTM, thanks again @sjackman!

@MikeMcQuaid MikeMcQuaid merged commit 4e7bb2f into Homebrew:master Dec 21, 2017
@sjackman sjackman deleted the brew-version branch December 21, 2017 17:45
@sjackman
Copy link
Member Author

Before this patch, the command

HOMEBREW_VERSION="$(git -C "$HOMEBREW_REPOSITORY" describe --tags --dirty --abbrev=7 2>/dev/null)"

is running using the git executable found in PATH.
After this patch, the command is run using the git shell function, which runs $HOMEBREW_LIBRARY/Homebrew/shims/scm/git.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants