Use hgpath instead of "hg" to fix --HEAD hg builds #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Homebrew#3628. With environment filtering, hg was no longer in the path, so make sure to provide the path when calling hg commands. last_commit was the source of the problem in Homebrew#3628 but I fixed source_modified_time as well. I didn't see any others with this problem.
4 tasks
ilovezfs
approved these changes
Jan 8, 2018
|
This works for me in testing @scpeters! The commit message is slightly non-standard, though. |
|
Nice catch @scpeters, thanks again for a great PR! |
|
@ilovezfs I guess it would have been better if it started with "download_strategy:"? I was getting sleepy. I'll try to remember next time. |
|
@scpeters no worries. Yup "download_strategy:" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3628.
With environment filtering, hg was no longer in the path, so make sure to provide the path when calling hg commands (the other functions in download_strategy use hgpath).
last_commitwas the source of the problem in #3628, but I fixedsource_modified_timeas well since it had the same problem. I didn't see any other functions using "hg".brew testswith your changes locally?