upgrade: skip formula if upgrade fails due to unsatisfied requirement. #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than blocking the rest of the formulae from being installed by `brew upgrade` print the requirement failure messages (already done) and an error stating requirements weren't satisfied and then continue to upgrade the rest of the formulae.
MikeMcQuaid
changed the title
ilovezfs
approved these changes
Jan 8, 2018
4 tasks
|
Slight nitpick here: the exit status is zero despite the error. |
This was referenced Jan 9, 2018
|
This is a great improvement on the original behavior, although IMO it is also desirable that the exit status is non-erring. That way a one-liner such as |
|
@ylluminarious the error status in this case will continue to report an error, because an error occurred and the command was not able to successfully complete its task. If you want to cleanup even if an error occurred while upgrading, you can just do |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than blocking the rest of the formulae from being installed by
brew upgradeprint the requirement failure messages (already done) and an error stating requirements weren't satisfied and then continue to upgrade the rest of the formulae.