Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish_bottle_file_on_bintray: Use f.full_name #3689

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Jan 16, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

FormulaInfoFromJson.lookup(f.name) fails when there is more than one formula with that short name.

@MikeMcQuaid MikeMcQuaid merged commit edc6efd into Homebrew:master Jan 18, 2018
@MikeMcQuaid
Copy link
Member

Thanks again @sjackman!

@sjackman sjackman deleted the pull-json branch January 18, 2018 17:08
@sjackman
Copy link
Member Author

Thanks for merging, Mike!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants